Codecov Report

❌ Patch coverage is 97.08738% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.86%. Comparing base (102b941) to head (79eae42).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   97.86%   97.86%   -0.01%     
==========================================
  Files         635      637       +2     
  Lines       69612    69818     +206     
==========================================
+ Hits        68126    68325     +199     
- Misses       1486     1493       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Agentic Review Report

Structural Check

Structural Review: model QuadraticDiophantineEquations

Structural Completeness

Blacklisted Files

• PASS — no blacklisted autogenerated files were committed

Build Status

• make test: PASS
• make clippy: PASS

Semantic Review

• evaluate() correctness: OK — the model enumerates only x, derives y from c - a*x^2, rejects non-positive and non-divisible remainders, and returns Or(false) for invalid configs.
• dims() correctness: OK — vec![max_x] matches the x-only search space, and vec![0] correctly yields zero configurations under DimsIterator when c < a.
• Size getter consistency: ISSUE — the user-facing size metadata exposes only c_val, which leaks an implementation detail and diverges from the linked-issue bundle's mathematical a, b, c naming.
• Weight handling: OK — not applicable for this unweighted feasibility model.

Issue Compliance

Summary

• 16/16 structural checks passed
• 8/8 issue-compliance checks passed
• ISSUE — size metadata exposes c_val instead of the mathematical parameter naming used in the issue packet

Quality Check

Quality Review

Design Principles

• DRY: OK — the implementation is self-contained and follows existing model/create wiring patterns without unnecessary duplication.
• KISS: OK — encoding only x and deriving y is the simplest faithful representation of the problem.
• HC/LC: OK — model logic, CLI wiring, docs, and tests remain in their expected modules.

HCI (if CLI/MCP changed)

• Error messages: OK — pred create QuadraticDiophantineEquations --coeff-a 3 fails with an actionable missing-flag message, and failed default solve points users to --solver brute-force.
• Discoverability: ISSUE — pred list and pred show QuadraticDiophantineEquations expose O(sqrt(c_val)) and Size fields: c_val, leaking an implementation-specific getter name into user-facing catalog output (src/models/algebraic/quadratic_diophantine_equations.rs:29, :102, :202).
• Consistency: ISSUE — the new paper example advertises pred solve qde.json, but the CLI default solver is ILP and this model has no ILP reduction path (docs/paper/reductions.typ:3281).
• Least surprise: ISSUE — following the documented command fails with No reduction path from QuadraticDiophantineEquations to ILP; the working command is pred solve qde.json --solver brute-force.
• Feedback: OK — the solve failure includes the correct brute-force hint.

Test Quality

• Naive test detection: ISSUE
  • The added unit tests cover model semantics well, but none of the added coverage exercises the changed CLI/help/doc path, so the broken pred solve qde.json example and the c_val metadata leak were not caught before review.

Issues

Critical (Must Fix)

• docs/paper/reductions.typ:3281 documents pred solve qde.json, but that exact command fails on this PR because QuadraticDiophantineEquations has no reduction path to ILP. Reproduced with target/debug/pred solve /tmp/qde-review-812.json -> Error: No reduction path from QuadraticDiophantineEquations to ILP.

Important (Should Fix)

• src/models/algebraic/quadratic_diophantine_equations.rs:29, :102, and :202 make user-facing catalog output show c_val instead of the mathematical parameter name c. Reproduced in both pred list and pred show QuadraticDiophantineEquations.
• The changed CLI/doc flow lacks automated coverage: no test currently exercises the advertised solve command for this new model.

Minor (Nice to Have)

• None.

Summary

• Documented default solve path is broken for the new model because no ILP route exists.
• User-facing catalog metadata leaks the internal getter name c_val.
• Added tests are strong for model semantics, but they miss the changed CLI/doc workflow.

Agentic Feature Tests

Feature Test Report: problem-reductions

Date: 2026-03-29
Project type: Rust library + CLI
Features tested: QuadraticDiophantineEquations model
Profile: ephemeral
Use Case: A downstream CLI user wants to discover the new model, inspect it, create the documented example instance, and solve it using the commands shown in project docs.
Expected Outcome: The model should appear in the catalog, pred show should describe it cleanly, pred create --example QuadraticDiophantineEquations should produce a valid instance, and the paper's pred solve qde.json command should solve that instance.
Verdict: fail
Critical Issues: 1

Summary

Per-Feature Details

QuadraticDiophantineEquations model

• Role: downstream CLI user testing a newly added model from docs alone
• Use Case: inspect the model, create the documented example, and solve it
• What they tried: target/debug/pred list; target/debug/pred show QuadraticDiophantineEquations; target/debug/pred show QDE; target/debug/pred create --example QuadraticDiophantineEquations -o /tmp/qde-review-812.json; target/debug/pred create QuadraticDiophantineEquations --coeff-a 3 --coeff-b 5 --rhs 53 -o /tmp/qde-manual-812.json; target/debug/pred solve /tmp/qde-review-812.json; target/debug/pred solve /tmp/qde-review-812.json --solver brute-force; target/debug/pred evaluate /tmp/qde-review-812.json --config 0
• Discoverability: Partial. The model is present in pred list, and alias QDE resolves correctly, but pred list / pred show surface c_val, which looks like an internal API symbol rather than the mathematical parameter c.
• Setup: Yes. No extra setup was needed once the workspace binary was built.
• Functionality: Partial. Example creation, manual creation, alias resolution, evaluation, and brute-force solve all work. Default solve does not.
• Expected vs Actual Outcome: Expected the paper's pred solve qde.json example to work verbatim. Actual result: that command fails because the default ILP solver has no path from QuadraticDiophantineEquations to ILP; adding --solver brute-force makes the example work.
• Blocked steps: None.
• Friction points: The documented solve command is wrong for this model; user-facing output leaks c_val.
• Doc suggestions: Update the paper command to pred solve qde.json --solver brute-force (or add a solve path/default fallback), and expose c rather than c_val in catalog metadata.

Expected vs Actual Outcome

• Example creation: achieved
• Manual create with explicit flags: achieved
• Example solve as documented: not achieved
• Example solve with explicit brute-force solver: achieved

Issues Found

1. Confirmed — Critical: pred solve qde.json fails because there is no ILP reduction path for this model.
2. Confirmed — Important: pred list / pred show leak the internal getter name c_val into user-facing output.

Suggestions

• Fix the paper example or solver behavior so the documented solve path works.
• Clean up size-field / complexity naming so user-facing output uses mathematical terms.

Generated by review-pipeline